Skip to content

add ut for kv tansfer module #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2025
Merged

add ut for kv tansfer module #1531

merged 8 commits into from
Jul 2, 2025

Conversation

@xudongLi-cmss
Copy link
Contributor

@xudongLi-cmss xudongLi-cmss commented Jun 30, 2025

What this PR does / why we need it?

test kv data transfer contains connect,pipe,buffer

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI passed with new added test.

@xudongLi-cmss
add ut for kv tansfer module
ee30ab7 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@xudongLi-cmss
Copy link
Contributor Author

xudongLi-cmss commented Jun 30, 2025

@Yikun help ro review my ut code

Yikun
Yikun reviewed Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name should be test_xxx

tests/ut/distributed/kv_transfer/simple_buffer_test.py
self.deallocate_buffer = MagicMock()


class TestSimpleBuffer(unittest.TestCase):
Copy link
Collaborator

@Yikun Yikun Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inherit from

vllm-ascend/tests/ut/base.py

Line 6 in 8013634

class TestBase(unittest.TestCase):

to make sure the patch applied.

tests/ut/distributed/kv_transfer/simple_pipe_test.py Outdated
self.assertIsNotNone(result)


if __name__ == '__main__':
Copy link
Collaborator

@Yikun Yikun Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed

@xudongLi-cmss
fix file name and test main for kv tansfer UT
51adfb6 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@MengqingCao MengqingCao mentioned this pull request Jul 1, 2025
Open
93 tasks
xudongLi-cmss and others added 6 commits July 1, 2025 11:08
@xudongLi-cmss
fix file form windows to unix and pass format.sh
9cb128b 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@xudongLi-cmss
modify test simple pipe file
e0b2c7d 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@MengqingCao
code format
d812106 
Signed-off-by: MengqingCao <cmq0113@163.com>
@xudongLi-cmss
modify simple connector file at torch npu
00efe6c 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@xudongLi-cmss
del recv kv cache run in cpu
72fd547 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@xudongLi-cmss
fix format check
1fea468 
Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 99.03382% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.00%. Comparing base (c30ddb8) to head (1fea468).
⚠️ Report is 609 commits behind head on main.

Files with missing lines Patch % Lines
...sts/ut/distributed/kv_transfer/test_simple_pipe.py 97.05% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   27.39%   37.00%   +9.61%     
==========================================
  Files          56       70      +14     
  Lines        6191     7877    +1686     
==========================================
+ Hits         1696     2915    +1219     
- Misses       4495     4962     +467
Flag Coverage Δ
unittests 37.00% <99.03%> (+9.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xudongLi-cmss
Copy link
Contributor Author

xudongLi-cmss commented Jul 2, 2025

@MengqingCao @Yikun help me to review my UT code

wangxiyuan
wangxiyuan approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@wangxiyuan wangxiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wangxiyuan wangxiyuan merged commit 7fc1a98 into vllm-project:main Jul 2, 2025
9 of 11 checks passed
ZhengWG pushed a commit to ZhengWG/vllm-ascend that referenced this pull request Jul 3, 2025
@xudongLi-cmss @MengqingCao @ZhengWG
add ut for kv tansfer module (vllm-project#1531)
f361e06 
### What this PR does / why we need it?
test kv data transfer contains connect,pipe,buffer

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added test.

---------

Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Co-authored-by: lixudong <lixudong@cmss.chinamobile.com>
Co-authored-by: MengqingCao <cmq0113@163.com>
Signed-off-by: ZhengWG <zwg0606@gmail.com>
ZhengWG pushed a commit to ZhengWG/vllm-ascend that referenced this pull request Jul 3, 2025
@xudongLi-cmss @MengqingCao @ZhengWG
add ut for kv tansfer module (vllm-project#1531)
cb7fa23 
### What this PR does / why we need it?
test kv data transfer contains connect,pipe,buffer

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added test.

---------

Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Co-authored-by: lixudong <lixudong@cmss.chinamobile.com>
Co-authored-by: MengqingCao <cmq0113@163.com>
Signed-off-by: ZhengWG <zwg0606@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
@xudongLi-cmss @MengqingCao
add ut for kv tansfer module (vllm-project#1531)
152c3f2 
### What this PR does / why we need it?
test kv data transfer contains connect,pipe,buffer

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added test.

---------

Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Co-authored-by: lixudong <lixudong@cmss.chinamobile.com>
Co-authored-by: MengqingCao <cmq0113@163.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
@xudongLi-cmss @MengqingCao @Angazenn
add ut for kv tansfer module (vllm-project#1531)
d936aba 
### What this PR does / why we need it?
test kv data transfer contains connect,pipe,buffer

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added test.

---------

Signed-off-by: lixudong <lixudong@cmss.chinamobile.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Co-authored-by: lixudong <lixudong@cmss.chinamobile.com>
Co-authored-by: MengqingCao <cmq0113@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yikun Yikun Yikun left review comments

@wangxiyuan wangxiyuan wangxiyuan approved these changes

Assignees

No one assigned

Labels

module:tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xudongLi-cmss @Yikun @wangxiyuan @MengqingCao